Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the overflowing text special-case from scrollIntoView (issue 15714) #15721

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

With the changes made in PR #14564 this should no longer be necessary now, however we still need to keep the scrollMatches parameter to handle textLayers with markedContent correctly when searching.

… 15714)

With the changes made in PR 14564 this *should* no longer be necessary now, however we still need to keep the `scrollMatches` parameter to handle textLayers with markedContent correctly when searching.
@Snuffleupagus Snuffleupagus linked an issue Nov 22, 2022 that may be closed by this pull request
@Snuffleupagus
Copy link
Collaborator Author

@calixteman For testing purposes, you should have access to PDF document from issue #5355 in the archive I sent you earlier.

/botio integrationtest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/cc3261129dae4bd/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/80e5d4a2b81cbb2/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/cc3261129dae4bd/output.txt

Total script time: 4.12 mins

  • Integration Tests: Passed

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/17fe14d3cf63079/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/17fe14d3cf63079/output.txt

Total script time: 1.26 mins

Published

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/80e5d4a2b81cbb2/output.txt

Total script time: 42.49 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor

/botio-windows integrationtest

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/ea1e190996ba2b3/output.txt

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Snuffleupagus Snuffleupagus merged commit a0db817 into mozilla:master Nov 22, 2022
@Snuffleupagus Snuffleupagus deleted the issue-15714 branch November 22, 2022 13:51
@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/ea1e190996ba2b3/output.txt

Total script time: 50.88 mins

  • Integration Tests: FAILED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove useless (?) check in ui_utils::scrollIntoView
3 participants