Move the _isOffscreenCanvasSupported property to the base Annotation class
#15699
Conversation
…on` class Having just played around with adding FreeText-annotations and then trying to print, there were `FreeTextAnnotation: OffscreenCanvas is not supported, annotation may not render correctly.` messages printed in the console. The reason for this is that `FreeTextAnnotation` inherits from `MarkupAnnotation`, however only `WidgetAnnotation` actually defines the `_isOffscreenCanvasSupported` property.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/19ad16e0f3bfcb2/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/c29e64befc30132/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/19ad16e0f3bfcb2/output.txt Total script time: 26.03 mins
Image differences available at: http://54.241.84.105:8877/19ad16e0f3bfcb2/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/c29e64befc30132/output.txt Total script time: 32.86 mins
Image differences available at: http://54.193.163.58:8877/c29e64befc30132/reftest-analyzer.html#web=eq.log |
|
This clearly fixes the relevant annotation-tests, so that's good :-) I'm guessing that all of the movement in Firefox on the Windows bot is caused by a browser update (to version 109), while I've checked a few cases without finding any "real" regressions there's so much to check so I'm just assuming that everything is fine. /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9d0849e981320b1/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/b96c26f99c56003/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/9d0849e981320b1/output.txt Total script time: 21.56 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/b96c26f99c56003/output.txt Total script time: 26.36 mins
|
Having just played around with adding FreeText-annotations and then trying to print, there were
FreeTextAnnotation: OffscreenCanvas is not supported, annotation may not render correctly.messages printed in the console.The reason for this is that
FreeTextAnnotationinherits fromMarkupAnnotation, however onlyWidgetAnnotationactually defines the_isOffscreenCanvasSupportedproperty.