Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize fullwidth, halfwidth and circled chars when searching #15694

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Normalize fullwidth, halfwidth and circled chars when searching #15694

merged 1 commit into from
Nov 14, 2022

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman linked an issue Nov 14, 2022 that may be closed by this pull request
FindController not supports FULLWIDTH LATIN CAPITAL #15690
Closed
Snuffleupagus
Snuffleupagus requested changes Nov 14, 2022
View reviewed changes
Snuffleupagus
Snuffleupagus approved these changes Nov 14, 2022
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing unit/integration tests; thank you!

@calixteman
Copy link
Contributor Author

/botio unittest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0ef209eac3154d7/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/856f419450f42d4/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/0ef209eac3154d7/output.txt

Total script time: 2.32 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/856f419450f42d4/output.txt

Total script time: 24.98 mins

  • Unit Tests: Passed

@calixteman
Copy link
Contributor Author

/botio integrationtest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c8e40b209189bf4/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d9f1aeaa967dd45/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/c8e40b209189bf4/output.txt

Total script time: 4.14 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/d9f1aeaa967dd45/output.txt

Total script time: 42.00 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 859335a into mozilla:master Nov 14, 2022
@calixteman calixteman deleted the 15690 branch November 14, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
text-selection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FindController not supports FULLWIDTH LATIN CAPITAL
3 participants
@calixteman @pdfjsbot @Snuffleupagus