Change the assert in Parser.findDefaultInlineStreamEnd to a non-PRODUCTION one
#15686
Conversation
Snuffleupagus
force-pushed
the
findDefaultInlineStreamEnd-assert
branch
from
f6f1f5a to
9f1fcab
Compare
…RODUCTION one Given that this `assert` is only intended to catch any implementation bugs in our code, and not actually to validate the PDF data directly[1], we can avoid making this function call unconditionally. --- [1] In those cases, for example a `FormatError` should have been thrown instead.
Snuffleupagus
force-pushed
the
findDefaultInlineStreamEnd-assert
branch
from
9f1fcab to
a1d48e3
Compare
Given that this PDF document is an interesting test-case for performance reasons, w.r.t. inline image caching, it probably can't hurt to add it to the test-suite to make it more readily available. Considering the contents of that PDF document I'm not sure if we can include it directly in the repository, hence why a *linked* test-case was choosen here.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/88cf6d8dd9f2010/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/fb4785aa3303529/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/fb4785aa3303529/output.txt Total script time: 25.76 mins
Image differences available at: http://54.241.84.105:8877/fb4785aa3303529/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/88cf6d8dd9f2010/output.txt Total script time: 33.88 mins
Image differences available at: http://54.193.163.58:8877/88cf6d8dd9f2010/reftest-analyzer.html#web=eq.log |
|
Thanks! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/dc85b28198870c2/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/afe1972f4a2c6ac/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/dc85b28198870c2/output.txt Total script time: 21.83 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/afe1972f4a2c6ac/output.txt Total script time: 25.70 mins
|
Given that this
assertis only intended to catch any implementation bugs in our code, and not actually to validate the PDF data directly[1], we can avoid making this function call unconditionally.[1] In those cases, for example a
FormatErrorshould have been thrown instead.