Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS] Avoid to trigger a commit event on 'ENTER' when the textfield is multiline #15631

Merged
merged 1 commit into from
Oct 27, 2022
Merged

[JS] Avoid to trigger a commit event on 'ENTER' when the textfield is multiline #15631

merged 1 commit into from
Oct 27, 2022

Conversation

calixteman
Copy link
Contributor

Closes #15627.

@calixteman
Copy link
Contributor Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_preview from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/5c2c4080fe670d2/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/5c2c4080fe670d2/output.txt

Total script time: 1.27 mins

Published

Snuffleupagus
Snuffleupagus approved these changes Oct 26, 2022
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing tests.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3516bc044a8b820/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/f1cb6e418468309/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/3516bc044a8b820/output.txt

Total script time: 4.17 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/f1cb6e418468309/output.txt

Total script time: 9.71 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 27b251a into mozilla:master Oct 27, 2022
@calixteman calixteman deleted the 15627 branch October 27, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
form-js
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TextWidgetAnnotationElement prevents Enter key on Multiline Inputs (rendered as TextArea)
3 participants
@calixteman @pdfjsbot @Snuffleupagus