-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback and try a *previous* generation if all else fails in XRef.indexObjects
(issue 15577)
#15589
Conversation
XRef.indexObjects
(issue 15577)XRef.indexObjects
(issue 15577)
…ndexObjects` (issue 15577) When we fail to find a usable PDF document `trailer` *and* there were errors during parsing, try and fallback to a *previous* generation as a last resort during fetching of uncompressed references. *Please note:* This will not affect "normal" PDF documents, with valid /XRef data, and even most *corrupt* documents should be completely unaffected by these changes.
a182b5c
to
de99f99
Compare
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/899bc8f03d70a79/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/1f975d45163d844/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/899bc8f03d70a79/output.txt Total script time: 26.20 mins
Image differences available at: http://54.241.84.105:8877/899bc8f03d70a79/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/1f975d45163d844/output.txt Total script time: 30.69 mins
Image differences available at: http://54.193.163.58:8877/1f975d45163d844/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch should be safe since it extends the current stuff and CI is green, so LGTM.
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0ca86d2fc7aa343/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d1bd8ef27d302fb/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/0ca86d2fc7aa343/output.txt Total script time: 21.47 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/d1bd8ef27d302fb/output.txt Total script time: 23.19 mins
|
When we fail to find a usable PDF document
trailer
and there were errors during parsing, try and fallback to a previous generation as a last resort during fetching of uncompressed references.Please note: This will not affect "normal" PDF documents, with valid /XRef data, and even most corrupt documents should be completely unaffected by these changes.