-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't trigger worker-thread cleanup when destruction has already started #15575
Don't trigger worker-thread cleanup when destruction has already started #15575
Conversation
Note how we're currently skipping all main-thread cleanup when document destruction has started, but for some reason we're still dispatching the "Cleanup" message. This seems like a simple oversight, since destruction will already invoke the `BasePdfManager.cleanup` method (on the worker-thread) to fully clear-out all caches.
Note in particular how the "Terminate" case triggers full clean-up, whereas it's only partial in the "Cleanup" case: Lines 792 to 806 in 9f5fd07
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4ff99bc3ac2fcf1/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4ff99bc3ac2fcf1/output.txt Total script time: 3.21 mins
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/16b5304fe72cb7e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/16b5304fe72cb7e/output.txt Total script time: 4.40 mins
|
Note how we're currently skipping all main-thread cleanup when document destruction has started, but for some reason we're still dispatching the "Cleanup" message. This seems like a simple oversight, since destruction will already invoke the
BasePdfManager.cleanup
method (on the worker-thread) to fully clear-out all caches.