[api-minor] Stop setting an id on the styleElement used with CSS font-loading
#15534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt-loading This is yet another small piece of clean-up of the `FontLoader`-code, since we've not used this `id`-property for anything ever since PR 6571 (which landed almost seven years ago). Furthermore, by default we're also not even using that code-path now since the Font Loading API will always be used when available. *Please note:* This is tagged `[api-minor]` since it's technically observable from the outside, however no user ought to be directly interacting with these CSS font rules.
…tests Given that `PDFDocumentProxy.destroy` is nothing but an alias for `PDFDocumentLoadingTask.destroy` calling both methods is obviously not useful.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0d81cde8f80e958/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b34db1ca32e5140/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/0d81cde8f80e958/output.txt Total script time: 25.33 mins
Image differences available at: http://54.241.84.105:8877/0d81cde8f80e958/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/b34db1ca32e5140/output.txt Total script time: 28.89 mins
Image differences available at: http://54.193.163.58:8877/b34db1ca32e5140/reftest-analyzer.html#web=eq.log |
Snuffleupagus
changed the title
id on the styleElement used with CSS font-loadingid on the styleElement used with CSS font-loading
timvandermeij
approved these changes
Oct 2, 2022
|
Nice find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is yet another small piece of clean-up of the
FontLoader-code, since we've not used thisid-property for anything ever since PR #6571 (which landed almost seven years ago). Furthermore, by default we're also not even using that code-path now since the Font Loading API will always be used when available.Please note: This is tagged
[api-minor]since it's technically observable from the outside, however no user ought to be directly interacting with these CSS font rules.