-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JS] Override the Doc.external
-getter to avoid alert
-modals on load (issue 15509)
#15512
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
…ad (issue 15509) This property is documented in https://web.archive.org/web/20201112021418if_/https://www.adobe.com/content/dam/acom/en/devnet/acrobat/pdfs/AcrobatDC_js_api_reference.pdf#G5.1977075 Given that PR 14207, which is *somewhat* similar, landed without tests that's hopefully fine here as well.
c350b5b
to
9769b3b
Compare
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/2a24de7210290a9/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/fa2be307f5bcd2c/output.txt |
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.241.84.105:8877/f058e12529bee9a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/ca3a299228dea2c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/fa2be307f5bcd2c/output.txt Total script time: 3.20 mins
|
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/f058e12529bee9a/output.txt Total script time: 5.50 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/2a24de7210290a9/output.txt Total script time: 11.88 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ca3a299228dea2c/output.txt Total script time: 11.70 mins
|
This property is documented in https://web.archive.org/web/20201112021418if_/https://www.adobe.com/content/dam/acom/en/devnet/acrobat/pdfs/AcrobatDC_js_api_reference.pdf#G5.1977075
Given that PR #14207, which is somewhat similar, landed without tests that's hopefully fine here as well.