Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XFA] - Avoid an exception when zooming on a XFA #15462

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

calixteman
Copy link
Contributor

No description provided.

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first I didn't understand why this happened, but then noticed this return value:

if (this.div) {
return XfaLayer.update(parameters);
}

and looking at that method things became clearer:
/**
* Update the XFA layer.
*
* @param {XfaLayerParameters} parameters
*/
static update(parameters) {
const transform = `matrix(${parameters.viewport.transform.join(",")})`;
parameters.div.style.transform = transform;
parameters.div.hidden = false;
}

@calixteman
Copy link
Contributor Author

/botio integration-test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Invalid

Command not implemented: integration.

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Invalid

Command not implemented: integration.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/3e558ad848f319e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6c414754308648a/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/6c414754308648a/output.txt

Total script time: 4.98 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/3e558ad848f319e/output.txt

Total script time: 12.67 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 5b4a44d into mozilla:master Sep 19, 2022
@calixteman calixteman deleted the update_xfa branch September 19, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants