-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback to a standard font when a Type1 font program is empty (issue 15292) #15397
Fallback to a standard font when a Type1 font program is empty (issue 15292) #15397
Conversation
… 15292) *Please note:* This is only a, hopefully generally helpful, work-around rather than a proper solution to issue 15292. There's something that's "special" about the Type1 fonts in the referenced PDF document, since we don't manage to find any actual font programs and thus cannot render anything. Given that it shouldn't make sense for a Type1 font program to ever be empty, since that means that there's no glyph-data to render, we simply fallback to a standard font to at least try and render *something* in these rare cases.
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/47d94475a10ca81/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6a855314e9fccae/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/6a855314e9fccae/output.txt Total script time: 26.06 mins
Image differences available at: http://54.241.84.105:8877/6a855314e9fccae/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/47d94475a10ca81/output.txt Total script time: 29.04 mins
Image differences available at: http://54.193.163.58:8877/47d94475a10ca81/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0ddbb874251dafc/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/3259168c5306682/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/0ddbb874251dafc/output.txt Total script time: 22.11 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/3259168c5306682/output.txt Total script time: 22.58 mins
|
Please note: This is only a, hopefully generally helpful, work-around rather than a proper solution to issue #15292.
There's something that's "special" about the Type1 fonts in the referenced PDF document, since we don't manage to find any actual font programs and thus cannot render anything.
Given that it shouldn't make sense for a Type1 font program to ever be empty, since that means that there's no glyph-data to render, we simply fallback to a standard font to at least try and render something in these rare cases.