Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to a standard font when a Type1 font program is empty (issue 15292) #15397

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

Please note: This is only a, hopefully generally helpful, work-around rather than a proper solution to issue #15292.

There's something that's "special" about the Type1 fonts in the referenced PDF document, since we don't manage to find any actual font programs and thus cannot render anything.
Given that it shouldn't make sense for a Type1 font program to ever be empty, since that means that there's no glyph-data to render, we simply fallback to a standard font to at least try and render something in these rare cases.

… 15292)

*Please note:* This is only a, hopefully generally helpful, work-around rather than a proper solution to issue 15292.

There's something that's "special" about the Type1 fonts in the referenced PDF document, since we don't manage to find any actual font programs and thus cannot render anything.
Given that it shouldn't make sense for a Type1 font program to ever be empty, since that means that there's no glyph-data to render, we simply fallback to a standard font to at least try and render *something* in these rare cases.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Sep 5, 2022

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/47d94475a10ca81/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 5, 2022

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6a855314e9fccae/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 5, 2022

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/6a855314e9fccae/output.txt

Total script time: 26.06 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 10
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/6a855314e9fccae/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Sep 5, 2022

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/47d94475a10ca81/output.txt

Total script time: 29.04 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/47d94475a10ca81/reftest-analyzer.html#web=eq.log

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Snuffleupagus Snuffleupagus merged commit b4b9ce8 into mozilla:master Sep 6, 2022
@Snuffleupagus
Copy link
Collaborator Author

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Sep 6, 2022

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0ddbb874251dafc/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 6, 2022

From: Bot.io (Windows)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/3259168c5306682/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 6, 2022

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/0ddbb874251dafc/output.txt

Total script time: 22.11 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Sep 6, 2022

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/3259168c5306682/output.txt

Total script time: 22.58 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the getEexecBlock-empty branch September 6, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants