Lookup image-data correctly in paintImageMaskXObjectGroup (issue 14990)
#14992
Conversation
Snuffleupagus
force-pushed
the
issue-14990
branch
2 times, most recently
from
6e4d7ff to
e6dfb28
Compare
…990) *This fixes a regression from PR 14754.* We didn't lookup the image-data correctly, with the result that we tried to render some ImageMasks using a string rather than the intended TypedArray. To make matters worse, this code-path was apparently not *properly* covered by existing test-cases.
Snuffleupagus
force-pushed
the
issue-14990
branch
from
e6dfb28 to
59dd4ea
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/832d8110ad24ff3/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/fe773864116fc02/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/832d8110ad24ff3/output.txt Total script time: 26.55 mins
Image differences available at: http://54.241.84.105:8877/832d8110ad24ff3/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/fe773864116fc02/output.txt Total script time: 27.98 mins
Image differences available at: http://54.193.163.58:8877/fe773864116fc02/reftest-analyzer.html#web=eq.log |
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7ab1701061308b4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/9ad86f7454c08cb/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/7ab1701061308b4/output.txt Total script time: 23.03 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/9ad86f7454c08cb/output.txt Total script time: 21.55 mins
|
This fixes a regression from PR #14754.
We didn't lookup the image-data correctly, with the result that we tried to render some ImageMasks using a string rather than the intended TypedArray. To make matters worse, this code-path was apparently not properly covered by existing test-cases.