(Don't Merge) #14940

calixteman · 2022-05-19T16:24:51Z

No description provided.

calixteman · 2022-05-19T16:25:10Z

/botio-windows integrationtest

pdfjsbot · 2022-05-19T16:25:11Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c704649ddfd2340/output.txt

calixteman · 2022-05-19T16:29:12Z

/botio-windows integrationtest

pdfjsbot · 2022-05-19T16:29:13Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/db2a9d370bee4d0/output.txt

pdfjsbot · 2022-05-19T16:36:41Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/db2a9d370bee4d0/output.txt

Total script time: 7.44 mins

Integration Tests: Passed

calixteman · 2022-05-19T16:37:10Z

Likely a temp failure on github's side.
/botio makeref

pdfjsbot · 2022-05-19T16:37:12Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5f3c018d24660b2/output.txt

pdfjsbot · 2022-05-19T16:37:12Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c0b3e0bb632d4b6/output.txt

Snuffleupagus · 2022-05-19T16:50:16Z

Likely a temp failure on github's side.

The thing that failed was the browsertest command, w.r.t. the reftest-analyzer, so I'm not sure that this actually tested the right thing!?

calixteman · 2022-05-19T16:54:17Z

If I understood correctly html_url is a property of the payload from a gh request.
So it should be fine with whatever command.
But I'll test with browsertest to be sure.

calixteman · 2022-05-19T16:55:40Z

/botio browsertest

pdfjsbot · 2022-05-19T16:55:42Z

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/82621fbb5e3361d/output.txt

pdfjsbot · 2022-05-19T16:55:42Z

From: Bot.io (Windows)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/641ecf2f433b128/output.txt

pdfjsbot · 2022-05-19T16:59:44Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/5f3c018d24660b2/output.txt

Total script time: 22.53 mins

Lint: Passed
Make references: Passed
Check references: Passed

pdfjsbot · 2022-05-19T17:03:03Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/c0b3e0bb632d4b6/output.txt

Total script time: 25.84 mins

Lint: Passed
Make references: Passed
Check references: Passed

pdfjsbot · 2022-05-19T17:21:17Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/82621fbb5e3361d/output.txt

Total script time: 21.54 mins

Regression tests: FAILED

  different ref/snapshot: 8

Image differences available at: http://54.241.84.105:8877/82621fbb5e3361d/reftest-analyzer.html#web=eq.log

pdfjsbot · 2022-05-19T17:26:36Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/641ecf2f433b128/output.txt

Total script time: 23.55 mins

Regression tests: FAILED

  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/641ecf2f433b128/reftest-analyzer.html#web=eq.log

Snuffleupagus · 2022-05-19T17:28:51Z

Unfortunately the issue still remains, given that when opening http://54.193.163.58:8877/641ecf2f433b128/reftest-analyzer.html#web=eq.log you cannot actually click on the "firefox-annotation-text-widget-forms-page1"-line and it's thus impossible to review the ref-test failures on the Windows-bot.

Snuffleupagus · 2022-05-19T17:39:58Z

It seems that something goes wrong in the following code, but only on the Windows bot:

pdf.js/test/resources/reftest-analyzer.js

Lines 284 to 295 in 60e9065

    
           const match = item.url.match(/\/mozilla\/(.*)/); 
        
           text = document.createTextNode(match ? match[1] : item.url); 
        
           if (item.images.length > 0) { 
        
             const a = document.createElement("a"); 
        
             a.id = i; 
        
             a.className = "image"; 
        
             a.href = "#"; 
        
             a.appendChild(text); 
        
             td.appendChild(a); 
        
           } else { 
        
             td.appendChild(text); 
        
           }

calixteman · 2022-05-19T18:05:56Z

/botio-windows browsertest

pdfjsbot · 2022-05-19T18:05:58Z

From: Bot.io (Windows)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a204f4af6236503/output.txt

calixteman · 2022-05-19T18:10:02Z

/botio-windows browsertest

pdfjsbot · 2022-05-19T18:10:05Z

From: Bot.io (Windows)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6c4660bd495a200/output.txt

pdfjsbot · 2022-05-19T18:34:53Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/6c4660bd495a200/output.txt

Total script time: 24.79 mins

Regression tests: FAILED

  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/6c4660bd495a200/reftest-analyzer.html#web=eq.log

calixteman · 2022-05-19T20:15:54Z

I don't know what the issue is, but at least I can reproduce locally.
I ran a makeref and then a browsertest and I got a lot of TEST-UNEXPECTED-FAIL....
Most of the links in the analyzers are ok but few of them are wrong.

calixteman · 2022-05-19T21:29:01Z

I think understand what the issue is.

the regexp here:

pdf.js/test/resources/reftest-analyzer.js

Line 228 in 60e9065

match = line.match(/^ {2}IMAGE[^:]*$(\d+)x(\d+)x(\d+)$: (.*)$/);

catch only integer outputScale
with my setup the outputScale is 1.5 and is set by:

pdf.js/test/driver.js

Line 615 in 60e9065

const outputScale = task.outputScale || window.devicePixelRatio;

So it's why it's failing locally.
When I connected to the VM in using a remote desktop connection, I think (I'm not sure at all) that the remote windows changed its resolution to fit mine, hence the bug...
So the first fix is to fix the regexp and I wonder if we should use window.devicePixelRatio in order to avoid any issue.
I checked the options to connect to the vm and I didn't find anything to fix the remote screen resolution, so I guess that each time I connect it we could have potential issues due to a different outputScale.

calixteman · 2022-05-20T08:30:56Z

/botio makeref

pdfjsbot · 2022-05-20T08:31:02Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/97cf8578f12d2f4/output.txt

pdfjsbot · 2022-05-20T08:31:02Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/5bc9759294aa068/output.txt

pdfjsbot · 2022-05-20T08:53:18Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/97cf8578f12d2f4/output.txt

Total script time: 22.24 mins

Lint: Passed
Make references: Passed
Check references: Passed

pdfjsbot · 2022-05-20T08:55:24Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/5bc9759294aa068/output.txt

Total script time: 24.35 mins

Lint: Passed
Make references: Passed
Check references: Passed

calixteman · 2022-05-20T09:33:12Z

/botio-windows browsertest

calixteman · 2022-05-20T10:06:08Z

/botio-windows browsertest

pdfjsbot · 2022-05-20T10:06:10Z

From: Bot.io (Windows)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/0703623bb319844/output.txt

calixteman · 2022-05-20T10:09:25Z

So the penultimate /botio-windows browsertest failed because of a html_url, I just restarted the process and the last command is ok...

pdfjsbot · 2022-05-20T10:29:36Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/0703623bb319844/output.txt

Total script time: 23.42 mins

Regression tests: FAILED

  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/0703623bb319844/reftest-analyzer.html#web=eq.log

calixteman · 2022-05-20T10:33:23Z

/botio-windows browsertest

pdfjsbot · 2022-05-20T10:33:28Z

From: Bot.io (Windows)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/03e295f0c9084ba/output.txt

pdfjsbot · 2022-05-20T10:54:41Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/03e295f0c9084ba/output.txt

Total script time: 21.21 mins

Regression tests: FAILED

  different ref/snapshot: 2175

Image differences available at: http://54.193.163.58:8877/03e295f0c9084ba/reftest-analyzer.html#web=eq.log

calixteman · 2022-05-20T10:55:52Z

/botio-windows makeref

pdfjsbot · 2022-05-20T10:55:56Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/cf86bfe945256d1/output.txt

pdfjsbot · 2022-05-20T11:17:44Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/cf86bfe945256d1/output.txt

Total script time: 21.79 mins

Lint: Passed
Make references: Passed
Check references: Passed

calixteman · 2022-05-20T11:20:13Z

/botio-windows browsertest

pdfjsbot · 2022-05-20T11:20:16Z

From: Bot.io (Windows)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/602a452e6676c5f/output.txt

pdfjsbot · 2022-05-20T11:41:03Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/602a452e6676c5f/output.txt

Total script time: 20.77 mins

Regression tests: FAILED

  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/602a452e6676c5f/reftest-analyzer.html#web=eq.log

timvandermeij · 2022-06-09T19:48:24Z

/botio-linux browsertest

pdfjsbot · 2022-06-09T19:48:25Z

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e835c65bc13eb8a/output.txt

pdfjsbot · 2022-06-09T20:10:38Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/e835c65bc13eb8a/output.txt

Total script time: 22.20 mins

Regression tests: FAILED

  different ref/snapshot: 57

Image differences available at: http://54.241.84.105:8877/e835c65bc13eb8a/reftest-analyzer.html#web=eq.log

timvandermeij · 2022-06-12T18:38:34Z

/botio-linux makeref

pdfjsbot · 2022-06-12T18:38:36Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d413ee44fcd9f43/output.txt

pdfjsbot · 2022-06-12T19:01:28Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/d413ee44fcd9f43/output.txt

Total script time: 22.86 mins

Lint: Passed
Make references: Passed
Check references: Passed

(Don't Merge)

17e569e

Snuffleupagus closed this May 20, 2022

timvandermeij mentioned this pull request Jun 9, 2022

Enable the unicorn/prefer-at ESLint plugin rule (PR 15008 follow-up) #15014

Merged

(Don't Merge) #14940

(Don't Merge) #14940

Conversation

calixteman commented May 19, 2022

calixteman commented May 19, 2022

pdfjsbot commented May 19, 2022

From: Bot.io (Windows)

Received

calixteman commented May 19, 2022

pdfjsbot commented May 19, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented May 19, 2022

From: Bot.io (Windows)

Success

calixteman commented May 19, 2022

pdfjsbot commented May 19, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented May 19, 2022

From: Bot.io (Windows)

Received

Snuffleupagus commented May 19, 2022 • edited Loading

calixteman commented May 19, 2022

calixteman commented May 19, 2022

pdfjsbot commented May 19, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented May 19, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented May 19, 2022

From: Bot.io (Linux m4)

Success

pdfjsbot commented May 19, 2022

From: Bot.io (Windows)

Success

pdfjsbot commented May 19, 2022

From: Bot.io (Linux m4)

Failed

pdfjsbot commented May 19, 2022

From: Bot.io (Windows)

Failed

Snuffleupagus commented May 19, 2022 • edited Loading

Snuffleupagus commented May 19, 2022

calixteman commented May 19, 2022

pdfjsbot commented May 19, 2022

From: Bot.io (Windows)

Received

calixteman commented May 19, 2022

pdfjsbot commented May 19, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented May 19, 2022

From: Bot.io (Windows)

Failed

calixteman commented May 19, 2022

calixteman commented May 19, 2022

calixteman commented May 20, 2022

pdfjsbot commented May 20, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented May 20, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented May 20, 2022

From: Bot.io (Linux m4)

Success

pdfjsbot commented May 20, 2022

From: Bot.io (Windows)

Success

calixteman commented May 20, 2022

calixteman commented May 20, 2022

pdfjsbot commented May 20, 2022

From: Bot.io (Windows)

Received

calixteman commented May 20, 2022

pdfjsbot commented May 20, 2022

From: Bot.io (Windows)

Failed

Snuffleupagus commented May 19, 2022 •

edited

Loading

Snuffleupagus commented May 19, 2022 •

edited

Loading