Only bundle the src/display/node_utils.js file in GENERIC-builds
#14870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This first of all simplifies the file, since we no longer need dummy-classes and can instead *directly* define the actual classes. Furthermore, and more importantly, this means that we no longer need to bundle this code in e.g. MOZCENTRAL-builds which reduces the size of *built* `pdf.js` file slightly.
Given that the `isNodeJS`-constant will, after PR 14858, *always* be `false` in non-GENERIC builds we can simplify a couple of `getDocument`-parameter default values slightly. The old format, with inline `PDFJSDev`-checks, wasn't exactly a wonder of readability; which was my fault.
|
/botio-linux browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e73fbc117b86d56/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/cee370ed515d2b7/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/cee370ed515d2b7/output.txt Total script time: 26.28 mins
Image differences available at: http://54.241.84.105:8877/cee370ed515d2b7/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/e73fbc117b86d56/output.txt Total script time: 26.73 mins
|
timvandermeij
approved these changes
May 4, 2022
|
Much better; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only bundle the
src/display/node_utils.jsfile in GENERIC-buildsThis first of all simplifies the file, since we no longer need dummy-classes and can instead directly define the actual classes.
Furthermore, and more importantly, this means that we no longer need to bundle this code in e.g. MOZCENTRAL-builds which reduces the size of built
pdf.jsfile slightly.Simplify a couple of
isNodeJS-dependentgetDocumentdefault valuesGiven that the
isNodeJS-constant will, after PR 14858, always befalsein non-GENERIC builds we can simplify a couple ofgetDocument-parameter default values slightly.The old format, with inline
PDFJSDev-checks, wasn't exactly a wonder of readability; which was my fault.