Ensure that worker-thread image caching doesn't break optional content (issue 14824) #14825
Conversation
…t (issue 14824) Currently we only insert optionalContent-data into the operatorList the first time that an image is parsed, which will (in hindsight) obviously cause problems for cached images. Hence we also need to insert the optionalContent-data in the various worker-thread image caches, such that it can be accessed in the fast-paths that are used to skip re-parsing of images. In order to reduce the amount of repeated code, this patch also adds a new `OperatorList`-method that takes care of inserting the necessary data in the operatorList.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/062c12c87677e3d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/062c12c87677e3d/output.txt Total script time: 2.56 mins Published |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ceac03e6890d875/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/52d92508b621251/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/ceac03e6890d875/output.txt Total script time: 22.97 mins
Image differences available at: http://54.241.84.105:8877/ceac03e6890d875/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/52d92508b621251/output.txt Total script time: 24.73 mins
Image differences available at: http://54.193.163.58:8877/52d92508b621251/reftest-analyzer.html#web=eq.log |
|
Looks really good! /botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 2 Live output at: http://54.193.163.58:8877/55daaa9d0c2057d/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/59eb0f8370303b1/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/59eb0f8370303b1/output.txt Total script time: 21.89 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/55daaa9d0c2057d/output.txt Total script time: 20.65 mins
|
Currently we only insert optionalContent-data into the operatorList the first time that an image is parsed, which will (in hindsight) obviously cause problems for cached images.
Hence we also need to insert the optionalContent-data in the various worker-thread image caches, such that it can be accessed in the fast-paths that are used to skip re-parsing of images.
In order to reduce the amount of repeated code, this patch also adds a new
OperatorList-method that takes care of inserting the necessary data in the operatorList.