Replace the --viewport-scale-factor CSS variable
#14780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CSS variable is only used together with the `annotationCanvasMap`-functionality in the canvas-code, however its value can be *trivially* computed by using the older `--zoom-factor` CSS variable together with the `PixelsPerInch`-structure. Rather than having *two different* CSS variables that are this closely linked, it seems better to simplify things by using just one CSS variable instead.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 1 Live output at: http://54.241.84.105:8877/2fb970fc4c36297/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/2fb970fc4c36297/output.txt Total script time: 2.61 mins Published |
timvandermeij
approved these changes
Apr 14, 2022
|
Thank you for doing all this CSS clean-up; really nice! |
As always, thank you for reviewing and merging these patches :-) Also, I think that there's most likely a bunch of additional clean-up, simplification, and modernization possible for the CSS rules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CSS variable is only used together with the
annotationCanvasMap-functionality in the canvas-code, however its value can be trivially computed by using the older--zoom-factorCSS variable together with thePixelsPerInch-structure.Rather than having two different CSS variables that are this closely linked, it seems better to simplify things by using just one CSS variable instead.