Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[src/display/api.js] Simplify the sendTest function, used with Worker initialization (PR 14291 follow-up) #14683

Merged
merged 2 commits into from
Mar 19, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

Given that we now only use Workers when postMessage transfers are supported, there's really no point in trying to send a "test" message without transfers present.
Hence, if postMessage transfers are not supported by the browser, we'll now fallback to "fake" Workers immediately instead. The comment about Opera is also removed, since it was originally added back in PR #983 and mentions Opera 11.60 which was released in 2011.

…adow`ed getter work-arounds (PR 13813, 13882 follow-up)

At the time private static class fields were to new, however that's no longer an issue and we can thus (ever so slightly) simplify the code.
…er initialization (PR 14291 follow-up)

Given that we now only use Workers when `postMessage` transfers are supported, there's really no point in trying to send a "test" message *without* transfers present.
Hence, if `postMessage` transfers are not supported by the browser, we'll now fallback to "fake" Workers immediately instead. The comment about Opera is also removed, since it was originally added back in PR 983 and mentions Opera `11.60` [which was released in 2011](https://en.wikipedia.org/wiki/History_of_the_Opera_web_browser#Version_11).
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/067871d39cdc30b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/96ff8d4d39ee98c/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/96ff8d4d39ee98c/output.txt

Total script time: 0.01 mins

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/067871d39cdc30b/output.txt

Total script time: 0.37 mins

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f8da0fdd536cf66/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/f8da0fdd536cf66/output.txt

Total script time: 0.01 mins

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.241.84.105:8877/32f736e20e9bb9a/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/32f736e20e9bb9a/output.txt

Total script time: 0.01 mins

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.241.84.105:8877/73381e2b1718c05/output.txt

@mozilla mozilla deleted a comment from pdfjsbot Mar 16, 2022
@mozilla mozilla deleted a comment from pdfjsbot Mar 16, 2022
@mozilla mozilla deleted a comment from pdfjsbot Mar 16, 2022
@mozilla mozilla deleted a comment from pdfjsbot Mar 16, 2022
@mozilla mozilla deleted a comment from pdfjsbot Mar 16, 2022
@mozilla mozilla deleted a comment from pdfjsbot Mar 16, 2022
@mozilla mozilla deleted a comment from pdfjsbot Mar 16, 2022
@mozilla mozilla deleted a comment from pdfjsbot Mar 16, 2022
@mozilla mozilla deleted a comment from pdfjsbot Mar 16, 2022
@brendandahl
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3247220d31b2fd0/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.193.163.58:8877/908d787e16884a1/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/3247220d31b2fd0/output.txt

Total script time: 23.33 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 5
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/3247220d31b2fd0/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/908d787e16884a1/output.txt

Total script time: 26.48 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Integration Tests: Passed
  • Regression tests: Passed

@timvandermeij timvandermeij merged commit 5de6af4 into mozilla:master Mar 19, 2022
@timvandermeij
Copy link
Contributor

Thank you!

@Snuffleupagus Snuffleupagus deleted the sendTest-cleanup branch March 19, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants