Build the web/viewer.css file used in the development viewer (i.e. gulp server)
#14675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
build-dev-CSS
branch
2 times, most recently
from
419505a to
bff8a8c
Compare
…`gulp server`) To allow using modern CSS features that currently only Mozilla Firefox supports[1], while still enabling development/testing in recent Google Chrome versions, we'll have to start building the `web/viewer.css` file with `gulp server` as well. In my testing, building the development CSS (and copying the images) takes *less than* `200 ms` on average which is hopefully an acceptable overhead for this sort of feature. --- [1] In particular `float`, with `inline-start`/`inline-end` values.
Given that we're now *building* the `web/viewer.css` file used in the development viewer, i.e. with `gulp server`, we no longer need to hard-code these `-webkit`-prefixed rules and can instead let Autoprefixer handle that for us.
Snuffleupagus
force-pushed
the
build-dev-CSS
branch
from
bff8a8c to
c557486
Compare
timvandermeij
approved these changes
Mar 16, 2022
|
Let's do this; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build the
web/viewer.cssfile used in the development viewer (i.e.gulp server)To allow using modern CSS features that currently only Mozilla Firefox supports[1], while still enabling development/testing in recent Google Chrome versions, we'll have to start building the
web/viewer.cssfile withgulp serveras well.In my testing, building the development CSS (and copying the images) takes less than
200 mson average which is hopefully an acceptable overhead for this sort of feature.[1] In particular
float, withinline-start/inline-endvalues.Remove the
-webkit-mask-image/-webkit-mask-imageCSS rulesGiven that we're now building the
web/viewer.cssfile used in the development viewer, i.e. withgulp server, we no longer need to hard-code these-webkit-prefixed rules and can instead let Autoprefixer handle that for us.