-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute the loca table endOffset
, of the "first" glyph, correctly (issue 14618)
#14629
Conversation
…issue 14618) When there are *multiple* empty glyphs at the start of the data, ensure that the "first" glyph gets a correct `endOffset` to avoid skipping it during parsing in the `sanitizeGlyph` function.
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/487c23ea5734542/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/8b3a474e79f1c14/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/487c23ea5734542/output.txt Total script time: 23.64 mins
Image differences available at: http://54.241.84.105:8877/487c23ea5734542/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/8b3a474e79f1c14/output.txt Total script time: 26.30 mins
Image differences available at: http://54.193.163.58:8877/8b3a474e79f1c14/reftest-analyzer.html#web=eq.log |
These changes worked fine for 2 original pdf files that had this issue as well 🥇👍 |
Looks good, thanks! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://54.241.84.105:8877/128fcb3598c82f2/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://54.193.163.58:8877/7fbb5138b0e54f6/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/128fcb3598c82f2/output.txt Total script time: 21.03 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/7fbb5138b0e54f6/output.txt Total script time: 21.31 mins
|
When there are multiple empty glyphs at the start of the data, ensure that the "first" glyph gets a correct
endOffset
to avoid skipping it during parsing in thesanitizeGlyph
function.