Simplify the fallback-logic in the default viewer
#14624
Conversation
After [bug 1705327](https://bugzilla.mozilla.org/show_bug.cgi?id=1705327) the `ChromeActions.fallback`-method is now just a stub[1], since the fallback bar was removed. Hence there's no good reason, as far as I can tell, to keep this code in the viewer itself when it's completely unused. --- [1] See https://searchfox.org/mozilla-central/rev/292d17c13daa61016fd082e2337297091d53a015/toolkit/components/pdfjs/content/PdfStreamConverter.jsm#575-581
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a3c596fe55ae9b3/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d57a83d15d562a8/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/d57a83d15d562a8/output.txt Total script time: 3.95 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/a3c596fe55ae9b3/output.txt Total script time: 6.84 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/309783a9aa937d8/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/309783a9aa937d8/output.txt Total script time: 2.47 mins Published |
|
Given the upstream patch I also don't really see a reason to keep this around; thanks! |
After bug 1705327 the
ChromeActions.fallback-method is now just a stub[1], since the fallback bar was removed.Hence there's no good reason, as far as I can tell, to keep this code in the viewer itself when it's completely unused.
[1] See https://searchfox.org/mozilla-central/rev/292d17c13daa61016fd082e2337297091d53a015/toolkit/components/pdfjs/content/PdfStreamConverter.jsm#575-581