Handle errors gracefully, in PartialEvaluator.buildFontPaths, when glyph path building fails #13381
Conversation
Snuffleupagus
force-pushed
the
buildFontPaths-ignoreErrors
branch
6 times, most recently
from
f26f65e to
f014697
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/574a6f7f58c78e0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/6e1d6870f7b8a49/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/574a6f7f58c78e0/output.txt Total script time: 26.48 mins
Image differences available at: http://54.67.70.0:8877/574a6f7f58c78e0/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/6e1d6870f7b8a49/output.txt Total script time: 30.04 mins
Image differences available at: http://3.101.106.178:8877/6e1d6870f7b8a49/reftest-analyzer.html#web=eq.log |
Snuffleupagus
force-pushed
the
buildFontPaths-ignoreErrors
branch
from
f014697 to
ea9cb8a
Compare
…glyph path building fails The building of glyph paths, in the `FontRendererFactory`, can fail in various ways for corrupt font data. However, we're currently not attempting to handle any such errors in the evaluator, which means that a single broken glyph *can* prevent an entire page from rendering. To address this we simply have to pass along, and check, the existing `ignoreErrors` option in `PartialEvaluator.buildFontPaths` similar to the rest of the `PartialEvaluator` code.
…ialEvaluator.translateFont` *This is a small piece of clean-up that I happened to notice while browsing the code.*
Snuffleupagus
force-pushed
the
buildFontPaths-ignoreErrors
branch
from
ea9cb8a to
c4429bc
Compare
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/34dbd548495b056/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/3d0b1b9df39b56c/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/3d0b1b9df39b56c/output.txt Total script time: 26.33 mins
Image differences available at: http://54.67.70.0:8877/3d0b1b9df39b56c/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/34dbd548495b056/output.txt Total script time: 29.40 mins
Image differences available at: http://3.101.106.178:8877/34dbd548495b056/reftest-analyzer.html#web=eq.log |
|
Thanks! |
The building of glyph paths, in the
FontRendererFactory, can fail in various ways for corrupt font data. However, we're currently not attempting to handle any such errors in the evaluator, which means that a single broken glyph can prevent an entire page from rendering.To address this we simply have to pass along, and check, the existing
ignoreErrorsoption inPartialEvaluator.buildFontPathssimilar to the rest of thePartialEvaluatorcode.