Re-factor and convert the code in src/display/pattern_helper.js to use standard classes
#13380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this patch only covers `TilingPattern`, since the `ShadingIRs`-implementation required additional re-factoring.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/2a6eb8e196809fb/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/1aa522acd89b0d5/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/2a6eb8e196809fb/output.txt Total script time: 26.08 mins
Image differences available at: http://54.67.70.0:8877/2a6eb8e196809fb/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/1aa522acd89b0d5/output.txt Total script time: 29.56 mins
Image differences available at: http://3.101.106.178:8877/1aa522acd89b0d5/reftest-analyzer.html#web=eq.log |
…js`, to use standard classes This patch replaces the old structure with an abstract base-class, which the new ShadingPattern classes then inherit from. The old `createMeshCanvasClosure` can now be removed, since it's not necessary any more with modern JavaScript, and the `createMeshCanvas` function is now instead a method on the new `MeshShadingPattern` class (avoids unnecessary parameter passing).
Snuffleupagus
force-pushed
the
pattern_helper-class
branch
from
17ca61f to
a984431
Compare
timvandermeij
approved these changes
May 16, 2021
|
Thank you for modernizing this code; looks much better like this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.