[Regression] Move the super-call in the PredictorStream-constructor to prevent errors (PR 13303)
#13337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or to prevent errors (PR 13303) *My apologies for breaking this; thankfully PR 13303 hasn't reach mozilla-central yet.* It's (obviously) necessary to initialize a `PredictorStream`-instance fully, since otherwise breakage may occur if there's errors during the actual stream parsing. To reproduce this issue, try opening the PDF document from issue 13051 locally and observe the following message in the console: ``` Warning: Invalid stream: "ReferenceError: this hasn't been initialised - super() hasn't been called" ```
|
Is it possible to add a test using a |
|
It actually turns out that I cannot reproduce this in any build, but only locally in Note that the intention is to get rid of SystemJS for local development, see PR #12563, however that's unfortunately still blocked by https://bugzilla.mozilla.org/show_bug.cgi?id=1247687 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My apologies for breaking this; thankfully PR #13303 hasn't reach mozilla-central yet.
It's (obviously) necessary to initialize a
PredictorStream-instance fully, since otherwise breakage may occur if there's errors during the actual stream parsing.To reproduce this issue, try opening the PDF document from issue #13051 locally and observe the following message in the console: