Enable the no-var linting rule in src/core/{crypto,function}.js
#13321
Conversation
This is done automatically with `gulp lint --fix` and the following
manual changes:
```diff
diff --git a/src/core/function.js b/src/core/function.js
index 878001057..b7e3e6ccf 100644
--- a/src/core/function.js
+++ b/src/core/function.js
@@ -131,7 +131,7 @@ function toNumberArray(arr) {
return arr;
}
-var PDFFunction = (function PDFFunctionClosure() {
+const PDFFunction = (function PDFFunctionClosure() {
const CONSTRUCT_SAMPLED = 0;
const CONSTRUCT_INTERPOLATED = 2;
const CONSTRUCT_STICHED = 3;
@@ -484,7 +484,9 @@ var PDFFunction = (function PDFFunctionClosure() {
// clip to domain
const v = clip(src[srcOffset], domain[0], domain[1]);
// calculate which bound the value is in
- for (var i = 0, ii = bounds.length; i < ii; ++i) {
+ const length = bounds.length;
+ let i;
+ for (i = 0; i < length; ++i) {
if (v < bounds[i]) {
break;
}
@@ -673,23 +675,21 @@ const PostScriptStack = (function PostScriptStackClosure() {
roll(n, p) {
const stack = this.stack;
const l = stack.length - n;
- let r = stack.length - 1,
- c = l + (p - Math.floor(p / n) * n),
- i,
- j,
- t;
- for (i = l, j = r; i < j; i++, j--) {
- t = stack[i];
+ const r = stack.length - 1;
+ const c = l + (p - Math.floor(p / n) * n);
+
+ for (let i = l, j = r; i < j; i++, j--) {
+ const t = stack[i];
stack[i] = stack[j];
stack[j] = t;
}
- for (i = l, j = c - 1; i < j; i++, j--) {
- t = stack[i];
+ for (let i = l, j = c - 1; i < j; i++, j--) {
+ const t = stack[i];
stack[i] = stack[j];
stack[j] = t;
}
- for (i = c, j = r; i < j; i++, j--) {
- t = stack[i];
+ for (let i = c, j = r; i < j; i++, j--) {
+ const t = stack[i];
stack[i] = stack[j];
stack[j] = t;
}
@@ -939,7 +939,7 @@ class PostScriptEvaluator {
// We can compile most of such programs, and at the same moment, we can
// optimize some expressions using basic math properties. Keeping track of
// min/max values will allow us to avoid extra Math.min/Math.max calls.
-var PostScriptCompiler = (function PostScriptCompilerClosure() {
+const PostScriptCompiler = (function PostScriptCompilerClosure() {
class AstNode {
constructor(type) {
this.type = type;
```
This is done automatically with `gulp lint --fix`.
timvandermeij
changed the title
src/core/{crypto,function}.js
timvandermeij
changed the title
src/core/{crypto,function}.jsno-var linting rule in src/core/{crypto,function}.js
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/15e159cb7dae089/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://3.101.106.178:8877/d4a01a3b4ec3df5/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/15e159cb7dae089/output.txt Total script time: 25.81 mins
Image differences available at: http://54.67.70.0:8877/15e159cb7dae089/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/d4a01a3b4ec3df5/output.txt Total script time: 29.83 mins
Image differences available at: http://3.101.106.178:8877/d4a01a3b4ec3df5/reftest-analyzer.html#web=eq.log |
|
Just a FYI, so that we avoid duplicate work here: I've started looking at splitting the Also, a warning if you feel like trying to fix |
|
Ah, thanks, I won't touch those files for now then. For the evaluator it might be best to first do some refactoring then before applying ESLint to make the process less error-prone. |
…ldn't be changed automatically by ESLint This is done in a separate commit due to the required number of changes so that reviewing is easier than in a plain-text diff in the commit message.
timvandermeij
force-pushed
the
src-core-no-var
branch
from
385d162 to
b661cf2
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/6489ac18872b0f7/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://3.101.106.178:8877/0f8b3b87a3a0e29/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/6489ac18872b0f7/output.txt Total script time: 3.79 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/0f8b3b87a3a0e29/output.txt Total script time: 6.26 mins
|
The commit messages contain more information about the individual changes.