-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JS] Use heap allocation when initializing quickjs sandbox #13286
Conversation
calixteman
commented
Apr 23, 2021
- In case of large string the sandbox initialization failed because of an OOM
- so allocate a new string in the heap
- and free it after use.
- it requires a quickjs update since we need to export some symbols (stringToNewUTF8 and free).
- In case of large string the sandbox initialization failed because of an OOM * so allocate a new string in the heap * and free it after use. - it requires a quickjs update since we need to export some symbols (stringToNewUTF8 and free).
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/49d598c4b0f1cae/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://3.101.106.178:8877/5a2f5fdc3fb866d/output.txt |
Do you have an example of a PDF document, that you can share, which triggers this behaviour? |
Sure, the pdf attached to this issue: |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/49d598c4b0f1cae/output.txt Total script time: 25.93 mins
Image differences available at: http://54.67.70.0:8877/49d598c4b0f1cae/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/5a2f5fdc3fb866d/output.txt Total script time: 28.46 mins
Image differences available at: http://3.101.106.178:8877/5a2f5fdc3fb866d/reftest-analyzer.html#web=eq.log |
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/32b7b597b81d091/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/32b7b597b81d091/output.txt Total script time: 4.54 mins Published |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, since sandbox initialization now works in the GENERIC viewer.