Convert done callbacks to async/await in the last two unit test files #13256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/81190c6cc7e0bc7/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://3.101.106.178:8877/29366d1df56254c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/81190c6cc7e0bc7/output.txt Total script time: 3.83 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/29366d1df56254c/output.txt Total script time: 5.27 mins
|
Snuffleupagus
approved these changes
Apr 17, 2021
timvandermeij
force-pushed
the
unit-test-async-await-pt4
branch
from
1622e97 to
d42f3d0
Compare
|
Thank you for the reviews! |
|
@timvandermeij Do you want to fix the font-tests as well, or should I do that? |
|
If you've already started on it, feel free to finish it. I won't have too much time the coming days, so otherwise it'll have to wait a couple of days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's highly recommended to use the
?w=1flag during review because of many indentation changes.