-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the yargs
package to the latest version
#13247
Conversation
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/390920c0d0a1aeb/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/cab4a9c910e7451/output.txt |
yargs
package to the latest versionyargs
package to the latest version
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/cab4a9c910e7451/output.txt Total script time: 29.28 mins
Image differences available at: http://3.101.106.178:8877/cab4a9c910e7451/reftest-analyzer.html#web=eq.log |
cdfb746
to
f9e32e9
Compare
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/390920c0d0a1aeb/output.txt Total script time: 60.00 mins |
/botio-linux test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ee457d5633232a3/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/ee457d5633232a3/output.txt Total script time: 25.91 mins
Image differences available at: http://54.67.70.0:8877/ee457d5633232a3/reftest-analyzer.html#web=eq.log |
While I wasn't able to figure out *exactly* why the old format didn't work, re-factoring the `parseOptions` function to use `yargs` differently "just worked" so that's hopefully good enough here. With these changes everything related to a *particular* option now appears in one place, rather than being spread out, which aids readability in my opinion. Also, the options are now sorted alphabetically, to make it easier to find a particular one. https://www.npmjs.com/package/yargs
f9e32e9
to
c988712
Compare
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/fef09b17e5732b3/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/326af14e9f90645/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/fef09b17e5732b3/output.txt Total script time: 3.89 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/326af14e9f90645/output.txt Total script time: 6.42 mins
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/98b1b8a2fb3209e/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/a24018650ab815a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/a24018650ab815a/output.txt Total script time: 3.74 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/98b1b8a2fb3209e/output.txt Total script time: 6.13 mins
|
Looks much nicer. Thank you for bringing this up-to-date! |
While I wasn't able to figure out exactly why the old format didn't work, re-factoring the
parseOptions
function to useyargs
differently "just worked" so that's hopefully good enough here.With these changes everything related to a particular option now appears in one place, rather than being spread out, which aids readability in my opinion. Also, the options are now sorted alphabetically, to make it easier to find a particular one.
https://www.npmjs.com/package/yargs