Convert done callbacks to async/await in more unit test files #13246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no asynchronous code involved here, so we can get rid of all done callbacks here and simply use the fact that if the function call ends without failed assertion that the test passed.
There is no asynchronous code involved here, so we can get rid of all done callbacks here and simply use the fact that if the function call ends without failed assertion that the test passed.
timvandermeij
changed the title
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/7f35a8ab9e3e9fd/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://3.101.106.178:8877/20bcb68ed05f83b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/7f35a8ab9e3e9fd/output.txt Total script time: 3.95 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/20bcb68ed05f83b/output.txt Total script time: 5.56 mins
|
Snuffleupagus
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the follow-up PR after #13222 that finalizes the conversion for the smaller and medium sized unit test files. Only three unit test files remain with done callbacks after this PR, but since they are bigger they will be done in a follow-up PR.
Using the
?w=1parameter will help during review for most commits.