-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement visibility expressions for optional content #13243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on!
I've not really reviewed the patch yet, but I've got two smaller suggestions to (maybe) improve overall readability.
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/359ab8cdd482933/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/359ab8cdd482933/output.txt Total script time: 4.38 mins Published |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with passing tests; thank you for implementing this!
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/31cc38f7979c897/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/675b22f2d18d58e/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/31cc38f7979c897/output.txt Total script time: 25.70 mins
Image differences available at: http://54.67.70.0:8877/31cc38f7979c897/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/675b22f2d18d58e/output.txt Total script time: 28.62 mins
Image differences available at: http://3.101.106.178:8877/675b22f2d18d58e/reftest-analyzer.html#web=eq.log |
Nice clean implementation; thanks! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/6a64634ff434806/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 4 Live output at: http://3.101.106.178:8877/038385020669e08/output.txt |
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/038385020669e08/output.txt Total script time: 26.25 mins
|
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/6a64634ff434806/output.txt Total script time: 60.00 mins
|
/botio-linux makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/2f2e14917d5c52d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/2f2e14917d5c52d/output.txt Total script time: 23.15 mins
|
Fixes #12097