Fix annotation input focus trap regression in Safari #13232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`setSelectionRange(0, 0)` added in mozilla@44b24fc for mozilla#12359, required only by Firefox ([bug](https://bugzilla.mozilla.org/show_bug.cgi?id=860329)), causes issues mozilla#13191, mozilla#12592 in Safari. `scrollLeft = 0` is a fix that breaks the focus trap in Safari while **keeping Firefox behavior same for mozilla#12359**.
|
@Snuffleupagus - here you go! |
calixteman
approved these changes
Apr 13, 2021
There was a problem hiding this comment.
According to https://bugzilla.mozilla.org/show_bug.cgi?id=860329#c8, it should be the correct way to fix so r+.
Thanks for doing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setSelectionRange(0, 0)added in 44b24fc for #12359, required only by Firefox (bug), causes issues #13191, #12592 in Safari.scrollLeft = 0is a fix that breaks the focus trap in Safari while keeping Firefox behavior same for #12359.Minimal case here: http://jsfiddle.net/mv08ekay/5/ (~10 LoC - no PDF.js)
scrollLeftanswer from @emilio (a Mozilla / Firefox developer):