Remove the unused "GetIsPureXfa" message handler; and avoid unnecessary parsing when no structTree is available (PR 13069 follow-up, PR 13221 follow-up) #13223
Conversation
…069 follow-up) Looking at the API, there's no code which actually sends this message. Most likely it's a left-over from a previous version of PR 13069, since the `isPureXfa` parameter is being included in the "GetDoc" message.
…e is available (PR 13221 follow-up) It's obviously (a bit) more efficient to return early in `Page.getStructTree`, rather than trying to first "parse" an *empty* structTree-root. *Somehow I didn't think of this yesterday, but this feels like a much better solution overall; sorry about the churn here!*
Snuffleupagus
force-pushed
the
worker-xfa-structTree-tweaks
branch
from
b38c99c to
9360c7c
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/0d8ca1281c7c298/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/429f910dd3c05f3/output.txt |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/429f910dd3c05f3/output.txt Total script time: 28.80 mins
Image differences available at: http://3.101.106.178:8877/429f910dd3c05f3/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/0d8ca1281c7c298/output.txt Total script time: 60.00 mins |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/23ebf7ecaf69e1c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/7aaabe70e8bf13c/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/23ebf7ecaf69e1c/output.txt Total script time: 24.89 mins
Image differences available at: http://54.67.70.0:8877/23ebf7ecaf69e1c/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/7aaabe70e8bf13c/output.txt Total script time: 28.62 mins
Image differences available at: http://3.101.106.178:8877/7aaabe70e8bf13c/reftest-analyzer.html#web=eq.log |
…dler Similar to all other data accesses, note e.g. the "GetDocJSActions" handler just above, we need to ensure that a `MissingDataException` isn't propagated to the main-thread if this data is accessed while the PDF document is still loading.
Snuffleupagus
force-pushed
the
worker-xfa-structTree-tweaks
branch
from
68082b2 to
54ef437
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/a8d85e7a4359279/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/a51b15b25453b18/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/a8d85e7a4359279/output.txt Total script time: 3.88 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/a51b15b25453b18/output.txt Total script time: 5.03 mins
|
|
Thanks! |
Remove the unused "GetIsPureXfa" message handler in the worker (PR 13069 follow-up)
Looking at the API, there's no code which actually sends this message. Most likely it's a left-over from a previous version of PR 13069, since the
isPureXfaparameter is being included in the "GetDoc" message.Avoid unnecessary parsing, in
Page.GetStructTree, when no structTree is available (PR 13221 follow-up)It's obviously (a bit) more efficient to return early in
Page.getStructTree, rather than trying to first "parse" an empty structTree-root.Somehow I didn't think of this yesterday, but this feels like a much better solution overall; sorry about the churn here!