-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuzzy-match the fontName, for TrueType Collection fonts, where the "name"-table is wrong (issue 13193) #13194
Conversation
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/744f9feb9f15bd8/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/aa6d7c7eafc7cb8/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/744f9feb9f15bd8/output.txt Total script time: 24.82 mins
Image differences available at: http://54.67.70.0:8877/744f9feb9f15bd8/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/aa6d7c7eafc7cb8/output.txt Total script time: 28.72 mins
Image differences available at: http://3.101.106.178:8877/aa6d7c7eafc7cb8/reftest-analyzer.html#web=eq.log |
…ame"-table is wrong (issue 13193) The fontName, as defined in the PDF document, cannot be found in *any* of the "name"-tables in the TrueType Collection font. To work-around that, this patch adds a *fallback* code-path to allow using an approximately matching fontName rather than outright failing.
9fa940a
to
f986ccd
Compare
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/1a4282452a886b2/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/1a4282452a886b2/output.txt Total script time: 4.40 mins Published |
Looks good to me; thanks! (And amazing how PDF generators found yet another way to mess things up.) /botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://3.101.106.178:8877/1fe8f5e9945d66d/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/7d8b113fece605f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/7d8b113fece605f/output.txt Total script time: 22.83 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/1fe8f5e9945d66d/output.txt Total script time: 26.43 mins
|
The fontName, as defined in the PDF document, cannot be found in any of the "name"-tables in the TrueType Collection font. To work-around that, this patch adds a fallback code-path to allow using an approximately matching fontName rather than outright failing.
Fixes #13193