Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XFA -- Display text content #13141

Merged
merged 1 commit into from
Apr 12, 2021
Merged

XFA -- Display text content #13141

merged 1 commit into from
Apr 12, 2021

Conversation

calixteman
Copy link
Contributor

  • display xhtml;
  • allow spaces in xhtml (xfa-spacerun:yes);
  • support column layout;
  • fix some border issues.

@calixteman calixteman requested a review from brendandahl March 25, 2021 15:57
@Snuffleupagus
Copy link
Collaborator

It looks like the xfa_tohtml_spec.js test isn't listed in https://github.com/mozilla/pdf.js/blob/master/test/unit/clitests.json, is this intentional or just a simple oversight (since other xfa-tests are present there)?

brendandahl
brendandahl suggested changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@brendandahl brendandahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits.

@calixteman
XFA -- Display text content
a4c9865 
  - display xhtml;
  - allow spaces in xhtml (xfa-spacerun:yes);
  - support column layout;
  - fix some border issues.
@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/8f3d005038959b1/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/7e3de62f318f0ef/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/8f3d005038959b1/output.txt

Total script time: 25.02 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/8f3d005038959b1/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/7e3de62f318f0ef/output.txt

Total script time: 28.72 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/7e3de62f318f0ef/reftest-analyzer.html#web=eq.log

@brendandahl brendandahl merged commit a53cd1c into mozilla:master Apr 12, 2021
Snuffleupagus
Snuffleupagus reviewed Apr 13, 2021
View reviewed changes
src/core/xfa/xhtml.js
@@ -65,99 +141,163 @@ function checkStyle(style) {
.join(";");
}

class A extends XmlObject {
const NoWhites = new Set(["body", "html"]);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be NoWhites -> NoWhitespace instead, right?

(I'd suggest just folding this change into a pending XFA-patch, to reduce unnecessary code churn.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus left review comments

@brendandahl brendandahl brendandahl requested changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@calixteman @Snuffleupagus @pdfjsbot @brendandahl @timvandermeij