Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of JPEG images without an EOI marker (issue 12841) #12842

Merged
merged 1 commit into from
Jan 10, 2021

Conversation

Snuffleupagus
Copy link
Collaborator

Given that the PDF document in the issue contains the same very large JPEG image three times, this patch includes a test-case where only the first page has been extracted from it.

Fixes #12841

Given that the PDF document in the issue contains the same very large JPEG image *three* times, this patch includes a test-case where only the first page has been extracted from it.
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Jan 9, 2021

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/247daa431665c4d/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jan 9, 2021

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/247daa431665c4d/output.txt

Total script time: 4.25 mins

Published

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Jan 9, 2021

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://3.101.106.178:8877/c0521732ece537a/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jan 9, 2021

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/2131efc456ed4a3/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jan 9, 2021

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/2131efc456ed4a3/output.txt

Total script time: 26.32 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/2131efc456ed4a3/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Jan 9, 2021

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/c0521732ece537a/output.txt

Total script time: 28.30 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/c0521732ece537a/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij merged commit f85b872 into mozilla:master Jan 10, 2021
@timvandermeij
Copy link
Contributor

Thanks!

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/ca4a4bf69f6f990/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 2

Live output at: http://3.101.106.178:8877/67ac383548244f8/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/ca4a4bf69f6f990/output.txt

Total script time: 24.54 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://3.101.106.178:8877/67ac383548244f8/output.txt

Total script time: 26.08 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the issue-12841 branch January 10, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JpegImage.parse - unknown marker: 0
3 participants