Pass in the "sandboxBundleSrc" option when calling DefaultExternalServices.createScripting
#12773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvices.createScripting` Similar to e.g. the "locale" option, this in *only* done for those build-targets where the "sandboxBundleSrc" is actually defined. With these changes we can remove an `AppOptions` dependency from the `web/generic_scripting.js` file, thus limiting *direct* `AppOptions` usage in the default viewer files.
Snuffleupagus
force-pushed
the
move-sandboxBundleSrc
branch
from
1346c29 to
47ff319
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/4ddedad20f6c436/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/b2c136c9f99ce7b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/4ddedad20f6c436/output.txt Total script time: 2.66 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/b2c136c9f99ce7b/output.txt Total script time: 3.63 mins
|
calixteman
approved these changes
Dec 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to e.g. the "locale" option, this in only done for those build-targets where the "sandboxBundleSrc" is actually defined.
With these changes we can remove an
AppOptionsdependency from theweb/generic_scripting.jsfile, thus limiting directAppOptionsusage in the default viewer files.