-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS -- Actions must be evaluated in global scope #12741
Conversation
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://3.101.106.178:8877/9318142df2bc6a7/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/a6f06006f3bab2d/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/a6f06006f3bab2d/output.txt Total script time: 25.69 mins
Image differences available at: http://54.67.70.0:8877/a6f06006f3bab2d/reftest-analyzer.html#web=eq.log |
} | ||
} | ||
|
||
// The doc properties must live in the global scope too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing it's not possible to make the global scope be the document?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example when I do console.println(this)
in acrobat, i get [object Doc]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that in a way this code change globalThis into a kind of doc.
About the second point, we can change the implementation of toString
.
In chrome, it displays [object global]
.
44da7e9
to
94d2009
Compare
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://3.101.106.178:8877/57e9b51f831227a/output.txt |
* All the public properties of doc are injected into globalThis, in order to make them available through `this` * Put event in the global scope too.
94d2009
to
167ff1a
Compare
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/57e9b51f831227a/output.txt Total script time: 27.01 mins
Image differences available at: http://3.101.106.178:8877/57e9b51f831227a/reftest-analyzer.html#web=eq.log |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ca0a610a7f20518/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://3.101.106.178:8877/6386ecf91fdf1c9/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/ca0a610a7f20518/output.txt Total script time: 25.81 mins
Image differences available at: http://54.67.70.0:8877/ca0a610a7f20518/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/6386ecf91fdf1c9/output.txt Total script time: 28.05 mins
Image differences available at: http://3.101.106.178:8877/6386ecf91fdf1c9/reftest-analyzer.html#web=eq.log |
/botio-linux unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/d35a7f6faba340c/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/d35a7f6faba340c/output.txt Total script time: 3.69 mins
|
/botio-linux unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/c6282640eced2ef/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/c6282640eced2ef/output.txt Total script time: 3.66 mins
|
this