Ensure that the pdf.sandbox.js is removed from the DOM on destroy, and unbreak the Chromium-extension (PR 12695 follow-up)
#12703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/dcc7cf2aeabf72c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/dcc7cf2aeabf72c/output.txt Total script time: 4.34 mins Published |
|
I think this will collide with #12689. |
Snuffleupagus
force-pushed
the
GenericScripting-rm-scriptElement
branch
from
bc92642 to
294ed33
Compare
…he DOM (PR 12695 follow-up) I completely missed this previously, but we obviously should remove the scriptElement as well to *really* clean-up everything properly. Given that there's multiple existing usages of `loadScript` in the code-base, the safest/quickest solution seemed to be to have call-sites opt-in to remove the scriptElement using a new parameter.
…d into its own helper method Since the `close` method has become quite large, this small re-factoring shouldn't hurt.
…close` and into its own helper method Since the `close` method has become quite large, this small re-factoring shouldn't hurt (and may also be useful with future changes to the `_initializeJavaScript` method).
…e used in the Chromium-extension While it's not entirely clear to me that it's ultimately desirable to use the `pdf.sandbox.js` in the Chromium-extension, given that the MOZCENTRAL-build uses `pdf.scripting.js` directly in a *custom* sandbox, the current state isn't that great since setting `enableScripting = true` with the Chromium-extension will currently fail completely. Hence this patch, which should at least unbreak things for now.
…mplementations, to a `createScripting` method Given that the GENERIC default viewer supports opening more than one document, and that a unique scripting-instance is now used for each document, the changes made in this patch seem appropriate.
Snuffleupagus
force-pushed
the
GenericScripting-rm-scriptElement
branch
from
294ed33 to
6218b9a
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 1 Live output at: http://54.67.70.0:8877/4dec2e3b1d5048e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/4dec2e3b1d5048e/output.txt Total script time: 4.16 mins Published |
timvandermeij
approved these changes
Dec 9, 2020
|
Looks like a good set of improvements to me too. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.