Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Puppeteer to version 5.3.1 #12442

Merged
merged 1 commit into from
Oct 4, 2020

Conversation

timvandermeij
Copy link
Contributor

@timvandermeij timvandermeij commented Oct 3, 2020

Fixes #11998.

@timvandermeij
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Oct 3, 2020

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/74d1c05fbb14839/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 3, 2020

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/9e5353336adf044/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 3, 2020

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/74d1c05fbb14839/output.txt

Total script time: 25.37 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/74d1c05fbb14839/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Oct 3, 2020

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/9e5353336adf044/output.txt

Total script time: 28.75 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/9e5353336adf044/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij marked this pull request as ready for review October 3, 2020 21:43
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that we can finally do this now; thanks for looking into this again!

@Snuffleupagus
Copy link
Collaborator

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Oct 4, 2020

From: Bot.io (Windows)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/796d3e92fe18fb8/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 4, 2020

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/328515fb39d6871/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 4, 2020

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/328515fb39d6871/output.txt

Total script time: 23.24 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Oct 4, 2020

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/796d3e92fe18fb8/output.txt

Total script time: 26.16 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@timvandermeij timvandermeij merged commit 4713170 into mozilla:master Oct 4, 2020
@timvandermeij timvandermeij deleted the upgrade-puppeteer branch October 4, 2020 13:01
@Snuffleupagus
Copy link
Collaborator

It seems that this also reduced the overall test run-times, on both bots, which is really nice :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove extraction log suppression code
3 participants