Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for missing appearances for hightlights, strikeout, squiggly and underline annotations. #12269

Merged
merged 1 commit into from
Sep 6, 2020

Conversation

calixteman
Copy link
Contributor

@calixteman calixteman commented Aug 23, 2020

This patch aims to fix:
https://bugzilla.mozilla.org/show_bug.cgi?id=1538111
and issue #6810.

@calixteman calixteman force-pushed the highlight branch 3 times, most recently from d372dc9 to 10e4c80 Compare August 23, 2020 17:10
@calixteman calixteman changed the title Add support for missing highlights Add support for missing appearances for hightlights, strikeout, squiggly and underline annotations. Aug 23, 2020
@calixteman
Copy link
Contributor Author

This patch is ready for review, thanks.

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/10e1656810233ef/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/10e1656810233ef/output.txt

Total script time: 3.38 mins

Published

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the viewer with the four files from my comment and they render exactly as expected. Nice work so far!

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Sep 6, 2020

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/edfb40bb4903bb1/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 6, 2020

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/c4d418562062e81/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 6, 2020

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/edfb40bb4903bb1/output.txt

Total script time: 27.37 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/edfb40bb4903bb1/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Sep 6, 2020

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/c4d418562062e81/output.txt

Total script time: 30.24 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/c4d418562062e81/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Sep 6, 2020

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/7a6616ce1f7ff5f/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 6, 2020

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/7a6616ce1f7ff5f/output.txt

Total script time: 3.55 mins

Published

@timvandermeij timvandermeij merged commit 20c8915 into mozilla:master Sep 6, 2020
@timvandermeij
Copy link
Contributor

Nice work; thanks!

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Sep 6, 2020

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 1

Live output at: http://54.215.176.217:8877/4c7c943eb034994/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 6, 2020

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/675a5d5b1a9ec01/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 6, 2020

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/675a5d5b1a9ec01/output.txt

Total script time: 25.63 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Sep 6, 2020

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/4c7c943eb034994/output.txt

Total script time: 27.89 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants