Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return the query with the findcontrolstate #12251

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Return the query with the findcontrolstate #12251

merged 1 commit into from
Aug 20, 2020

Conversation

DesWurstes
Copy link
Contributor

of D85140.

@Snuffleupagus any suggestions?

Snuffleupagus
Snuffleupagus requested changes Aug 20, 2020
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please note that in the upstream patch you'll need to extend the existing validation to ensure that the new parameter is a string, before including it in the "PDFJS:Parent:updateControlState" message, see https://searchfox.org/mozilla-central/rev/6cc48251bb97600fdf11a5b4c5f621bfc8606d55/toolkit/components/pdfjs/content/PdfStreamConverter.jsm#536-565

@DesWurstes
Copy link
Contributor Author

DesWurstes commented Aug 20, 2020 •
edited
Loading

Thanks!

Edit : ... Again!

Snuffleupagus
Snuffleupagus approved these changes Aug 20, 2020
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the final comment addressed.

Sorry about the back-and-forth here, it's slightly more difficult to review these types of patches that need to be split between Bugzilla/Github.

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/9d98452144d78b8/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/9d98452144d78b8/output.txt

Total script time: 3.24 mins

Published

@timvandermeij timvandermeij merged commit 2e95d08 into mozilla:master Aug 20, 2020
@timvandermeij
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DesWurstes @timvandermeij @pdfjsbot @Snuffleupagus