fix webpack config problem caused by breaking changes of worker-loader #12244
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is my first time to contribute to pdf.js. I already read the
Contributingwiki and try to follow it. But if I made any mistake please let me know. Thanks!The problem is caused by a breaking change from worker-loader(https://github.com/webpack-contrib/worker-loader/releases/tag/v3.0.0). It switches on ES module syntax by default now, so if pdfjs webpack config still uses CommonJS module,
esModule=falseneed to be set for worker-loader.