-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep the original class/function names when minifying code (issue 12209) #12210
Keep the original class/function names when minifying code (issue 12209) #12210
Conversation
f8d52f1
to
44aaae2
Compare
While this will obviously increase the size of the output of `gulp minified`/`gulp minified-es5` *slightly*, the resulting files are still a lot smaller than the non-minified builds. See https://github.com/terser/terser#minify-options for information about various Terser options.
44aaae2
to
ea5581b
Compare
…ys either error or warn (depending on the build) if a valid `Error` isn't found Having this present would have made debugging issues 11941 and 12209 so much quicker and easier.
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/fdf8ac5026a748e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/118544ed4e69615/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/fdf8ac5026a748e/output.txt Total script time: 3.71 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/118544ed4e69615/output.txt Total script time: 4.95 mins
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/803935ca3420e6d/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/a66473d63bd4628/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/a66473d63bd4628/output.txt Total script time: 26.80 mins
Image differences available at: http://54.67.70.0:8877/a66473d63bd4628/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/803935ca3420e6d/output.txt Total script time: 29.04 mins
Image differences available at: http://54.215.176.217:8877/803935ca3420e6d/reftest-analyzer.html#web=eq.log |
Nice work! |
While this will obviously increase the size of the output of
gulp minified
/gulp minified-es5
slightly, the resulting files are still a lot smaller than the non-minified builds.See https://github.com/terser/terser#minify-options for information about various Terser options.
Fixes #12209
Fixes #11941