Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable renderInteractiveForms by default. #12201

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

brendandahl
Copy link
Contributor

The forms seem far enough along to enable by default now.

@Snuffleupagus
Copy link
Collaborator

If this is enabled by default now, it does seem slightly strange to still warn/fallback in that case :-)

Hence, changing this line

pdf.js/web/app.js

Line 1418 in 7edc5cb

if (info.IsAcroFormPresent) {
to the following may be reasonable?

if (info.IsAcroFormPresent && !this.pdfViewer.renderInteractiveForms) {

(Rather than checking the AppOptions here, it probably makes sense to check what the viewer is actually using.)

@brendandahl
Copy link
Contributor Author

I think we'll also need to check if the the form is XFA. Unfortunately, it seems we'll still show the warning bar in some cases where things work fine with just acroform support, but the PDF has XFA and acrofroms e.g. f1040.pdf.

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the typo fixed.

web/app.js Outdated
info.IsAcroFormPresent &&
!this.pdfViewer.renderInteractiveForms
) {
console.warn("Warning: AcroForm support is not eabled");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: eabled -> enabled

@brendandahl
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/abbe3737ff0f15a/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.215.176.217:8877/2499ff43d3a6139/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/abbe3737ff0f15a/output.txt

Total script time: 27.12 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/abbe3737ff0f15a/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/2499ff43d3a6139/output.txt

Total script time: 29.86 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/2499ff43d3a6139/reftest-analyzer.html#web=eq.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants