-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable renderInteractiveForms by default. #12201
Conversation
If this is enabled by default now, it does seem slightly strange to still warn/fallback in that case :-) Hence, changing this line Line 1418 in 7edc5cb
if (info.IsAcroFormPresent && !this.pdfViewer.renderInteractiveForms) { (Rather than checking the |
I think we'll also need to check if the the form is XFA. Unfortunately, it seems we'll still show the warning bar in some cases where things work fine with just acroform support, but the PDF has XFA and acrofroms e.g. f1040.pdf. |
88836ad
to
9dd09ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with the typo fixed.
web/app.js
Outdated
info.IsAcroFormPresent && | ||
!this.pdfViewer.renderInteractiveForms | ||
) { | ||
console.warn("Warning: AcroForm support is not eabled"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: eabled
-> enabled
9dd09ee
to
da62be0
Compare
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.67.70.0:8877/abbe3737ff0f15a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.215.176.217:8877/2499ff43d3a6139/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/abbe3737ff0f15a/output.txt Total script time: 27.12 mins
Image differences available at: http://54.67.70.0:8877/abbe3737ff0f15a/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/2499ff43d3a6139/output.txt Total script time: 29.86 mins
Image differences available at: http://54.215.176.217:8877/2499ff43d3a6139/reftest-analyzer.html#web=eq.log |
The forms seem far enough along to enable by default now.