Convert the code in src/core/evaluator.js to use standard classes
#12060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` closure This will simplify the `class` conversion in the next patch, and with modern JavaScript the moved code is still limited to the current module scope. *Please note:* For improved consistency with our usual formatting, the `TILING_PATTERN`/`SHADING_PATTERN` constants where re-factored slightly.
This removes additional `// eslint-disable-next-line no-shadow` usage, which our old pseudo-classes necessitated. Most of the re-formatting changes, after the `class` definitions and methods were fixed, were done automatically by Prettier. *Please note:* I'm purposely not doing any `var` to `let`/`const` conversion here, since it's generally better to (if possible) do that automatically on e.g. a directory basis instead.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/a980fb634cd0f36/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/046724a4a3b22cd/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/a980fb634cd0f36/output.txt Total script time: 26.43 mins
Image differences available at: http://54.67.70.0:8877/a980fb634cd0f36/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/046724a4a3b22cd/output.txt Total script time: 28.68 mins
Image differences available at: http://54.215.176.217:8877/046724a4a3b22cd/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Jul 6, 2020
|
Looks good; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move some constants and helper functions out of the
PartialEvaluatorclosureThis will simplify the
classconversion in the next patch, and with modern JavaScript the moved code is still limited to the current module scope.Please note: For improved consistency with our usual formatting, the
TILING_PATTERN/SHADING_PATTERNconstants where re-factored slightly.Convert the code in
src/core/evaluator.jsto use standard classesThis removes additional
// eslint-disable-next-line no-shadowusage, which our old pseudo-classes necessitated.Most of the re-formatting changes, after the
classdefinitions and methods were fixed, were done automatically by Prettier.Please note: I'm purposely not doing any
vartolet/constconversion here, since it's generally better to (if possible) do that automatically on e.g. a directory basis instead.Much smaller and more manageable diff with https://github.com/mozilla/pdf.js/pull/12060/files?w=1