Small improvements in CFFCompiler.encodeNumber and CFFCompiler.encodeFloat
#12002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `isNaN` check is obviously redundant, since `NaN` is the only value that isn't equal to itself; see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/NaN#Examples The `parseFloat`/`parseInt` comparison would make sense if the `value` ever contains a String, which however is never actually the case. Besides looking through the code, I've also run the entire test-suite locally with `assert(typeof value === "number", "encodeNumber");` added at the top of the method and there were no failures. Hence we can simplify the "is integer" check a bit in the `CFFCompiler.encodeNumber` method.
…iler.encodeFloat` There's no particular reason for re-creating the regular expression over and over for every `encodeFloat` invocation, as far as I can tell.
Snuffleupagus
changed the title
CFFCompiler.encodeNumber and CFFCompiler.encodeNumberCFFCompiler.encodeNumber and CFFCompiler.encodeFloat
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/7699c6950420367/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/e91986e8f817c17/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/7699c6950420367/output.txt Total script time: 25.59 mins
Image differences available at: http://54.67.70.0:8877/7699c6950420367/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/e91986e8f817c17/output.txt Total script time: 28.88 mins
Image differences available at: http://54.215.176.217:8877/e91986e8f817c17/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Jun 15, 2020
|
Good find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the "is integer" checks in
CFFCompiler.encodeNumberThe
isNaNcheck is obviously redundant, sinceNaNis the only value that isn't equal to itself; see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/NaN#ExamplesThe
parseFloat/parseIntcomparison would make sense if thevalueever contains a String, which however is never actually the case. Besides looking through the code, I've also run the entire test-suite locally withassert(typeof value === "number", "encodeNumber");added at the top of the method and there were no failures.Hence we can simplify the "is integer" check a bit in the
CFFCompiler.encodeNumbermethod.Lazily initialize, and cache, the regular expression used in
CFFCompiler.encodeFloatThere's no particular reason for re-creating the regular expression over and over for every
encodeFloatinvocation, as far as I can tell.