[api-minor] Change the pageIndex, on PDFPageProxy instances, to a private property
#11716
Conversation
…rivate property This property has never been documented and/or *intentionally* exposed through the API, instead the `PDFPageProxy.pageNumber` property is the documented/intended API to use here. Hence pageIndex is changed to a "private" property on `PDFPageProxy` instances, and internal API functionality is also updated to *consistently* use `this._pageIndex` rather than a mix of formats.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f59be8b9dfb282e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/01af4ce1db70eb1/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/f59be8b9dfb282e/output.txt Total script time: 19.84 mins
Image differences available at: http://54.67.70.0:8877/f59be8b9dfb282e/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/01af4ce1db70eb1/output.txt Total script time: 25.02 mins
Image differences available at: http://54.215.176.217:8877/01af4ce1db70eb1/reftest-analyzer.html#web=eq.log |
|
Yes, this makes more sense and indeed, that property should have been private. Thanks for fixing this! |
This property has never been documented and/or intentionally exposed through the API, instead the
PDFPageProxy.pageNumberproperty is the documented/intended API to use here.Hence pageIndex is changed to a "private" property on
PDFPageProxyinstances, and internal API functionality is also updated to consistently usethis._pageIndexrather than a mix of formats.