Move IsLittleEndianCached/IsEvalSupportedCached to src/shared/util.js, and rename the isSpace helper function to isWhiteSpace
#11692
Conversation
…d/util.js` Rather than duplicating the lookup and caching in multiple files, it seems easier to simply move all of this functionality into `src/shared/util.js` instead. This will also help avoid a bunch of ESLint errors once the `no-shadow` rule is eventually enabled.
Trying to enable the ESLint rule `no-shadow`, against the `master` branch, would result in a fair number of errors in the `Glyph` class in `src/core/fonts.js`. Since the glyphs are exposed through the API, we can't very well change the `isSpace` property on `Glyph` instances. Thus the best approach seems, at least to me, to simply rename the `isSpace` helper function to `isWhiteSpace` which shouldn't cause any issues given that it's only used in the `src/core/` folder.
Snuffleupagus
changed the title
IsLittleEndianCached/IsEvalSupportedCached to srcil.js, and rename the isSpace helper function to isWhiteSpaceIsLittleEndianCached/IsEvalSupportedCached to src/shared/util.js, and rename the isSpace helper function to isWhiteSpace
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/50a45099b00d08f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/cc1d5574d7badfa/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/50a45099b00d08f/output.txt Total script time: 19.71 mins
Image differences available at: http://54.67.70.0:8877/50a45099b00d08f/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/cc1d5574d7badfa/output.txt Total script time: 25.13 mins
Image differences available at: http://54.215.176.217:8877/cc1d5574d7badfa/reftest-analyzer.html#web=eq.log |
|
Thank you! I have been a bit short on time lately, so splitting this up really helps. |
This is the first part in a series of patches that will try to split PR #11566 into smaller chunks, to make reviewing more feasible.
This is part of the work necessary in order to eventually enable the ESLint
no-shadowrule; see https://eslint.org/docs/rules/no-shadow