Prevent the zoom dropdown icon from being overridden when the element is :active (bug 1619595)
#11664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is `:active` (bug 1619595) This changes the dropdown icon from being set using the `background` CSS property, to being set with `::after` which is *similar* to all the other toolbar button icons (which use `::before`). Also tweaks the dropdown `background-color` on `:hover` slightly, since the other changes made it too light.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/1b64885012db33e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/1b64885012db33e/output.txt Total script time: 2.51 mins Published |
timvandermeij
approved these changes
Mar 4, 2020
|
This does look better. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the dropdown icon from being set using the
backgroundCSS property, to being set with::afterwhich is similar to all the other toolbar button icons (which use::before).Also tweaks the dropdown
background-coloron:hoverslightly, since the other changes made it too light.Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1619595