Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gulp lint to support passing of the --fix argument on the command line #11605

Merged
merged 1 commit into from
Feb 17, 2020

Conversation

Snuffleupagus
Copy link
Collaborator

I've had this patch locally for awhile, but have apparently missed to upstream it.

This simplifies enabling of new ESLint rules, since most of them support automatic fixing of errors, without having to edit gulpfile.js or manually invoke ESLint directly.

…command line

*I've had this patch locally for awhile, but have apparently missed to upstream it.*

This simplifies enabling of new ESLint rules, since most of them support automatic fixing of errors, without having to edit `gulpfile.js` or manually invoke ESLint directly.
@Snuffleupagus
Copy link
Collaborator Author

/botio lint

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_lint from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/c8bc5147d93e5a8/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_lint from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/8c3277dbeeca36c/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/8c3277dbeeca36c/output.txt

Total script time: 1.09 mins

  • Lint: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/c8bc5147d93e5a8/output.txt

Total script time: 2.54 mins

  • Lint: Passed

@timvandermeij timvandermeij merged commit e6aaf09 into mozilla:master Feb 17, 2020
@timvandermeij
Copy link
Contributor

Looks good!

@Snuffleupagus Snuffleupagus deleted the eslint-fix-arg branch February 17, 2020 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants