Move validation of chromium/preferences_schema.json to its own gulp task
#11602
Conversation
|
/botio lint |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b6fe7eed9167b9e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @timvandermeij received. Current queue size: 1 Live output at: http://54.215.176.217:8877/526eb52e5f5d53b/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/b6fe7eed9167b9e/output.txt Total script time: 1.11 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/526eb52e5f5d53b/output.txt Total script time: 2.48 mins
|
|
Hm, it looks like "files checked, no errors found" is no longer printed and that's what https://github.com/mozilla/botio-files-pdfjs/blob/master/on_cmd_lint.js checks for. Either that can be fixed, or we can change the bot command to look at the exit code instead of string matching. |
… task With the way that the `default_preferences.json` file is now generated at build time, the `gulp lint` task is now noticeably slower than before. This slowdown has been, and still is, somewhat annoying during the deployment of new ESLint rules. Hence this patch, which moves the `chromium/preferences_schema.json` validation from `gulp lint` and into a new `gulp lint-chromium` task instead. *Obviously* this new task is run as part of the `gulp npm-test` task, and thus through `npm test` on Node.js/Travis, such that it's still being tested as before.
Snuffleupagus
force-pushed
the
gulp-lint-chromium
branch
from
09797b1 to
9fd2402
Compare
Sorry, I didn't think to look for that! |
|
/botio lint |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/c7fdd93cdabea8b/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/2327d3a8571c1a9/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/2327d3a8571c1a9/output.txt Total script time: 1.11 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/c7fdd93cdabea8b/output.txt Total script time: 2.53 mins
|
|
Nice that we can run linting faster now. Thanks! |
With the way that the
default_preferences.jsonfile is now generated at build time, thegulp linttask is now noticeably slower than before. This slowdown has been, and still is, somewhat annoying during the deployment of new ESLint rules.Hence this patch, which moves the
chromium/preferences_schema.jsonvalidation fromgulp lintand into a newgulp lint-chromiumtask instead. Obviously this new task is run as part of thegulp npm-testtask, and thus throughnpm teston Node.js/Travis, such that it's still being tested as before.